Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] fix: local debug environment variables location in teams chef bot sample #2240

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

tecton
Copy link
Member

@tecton tecton commented Dec 19, 2024

Linked issues

closes: #2241

Details

Provide a list of your changes here. If you are fixing a bug, please provide steps to reproduce the bug.

  1. Fix bug that debugging in test tool is not working after local debugging.
    a. Clone the sample.
    b. Select "Debug (Edge)" and press "F5".
    c. Stop debugging and Select "Debug in Test Tool".
    d. The Test Tool will show authentication error.
  2. Fix the outdated lines in README file.

Change details

Environment variables like bot id and password will be read from .localConfigs in npm script.
So the env file update in teamsapp.local.yml should be ".localConfigs". Writing to ".env" file will pollute the Test Tool environment.

Describe your changes, with screenshots and code snippets as appropriate

code snippets:

screenshots:

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

Additional information

Feel free to add other relevant information below

@tecton tecton changed the title Teams Chef Bot Sample: fix environment variables location in local environment [JS] fix: local debug environment variables location in teams chef bot sample Dec 19, 2024
Copy link
Collaborator

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes! Please see comments :)

@corinagum
Copy link
Collaborator

@aycabas could you take a look?

@corinagum corinagum requested a review from aycabas January 7, 2025 21:52
@tecton
Copy link
Member Author

tecton commented Jan 8, 2025

The environment variables are loaded in npm script here.
So, I think there's no need to manually load in codes using dotenv. If ".env" is preferred filename, I could rename ".localConfigs" to ".env".

@aycabas
Copy link
Contributor

aycabas commented Jan 8, 2025

Nothing major that impacts us in this PR, thanks @corinagum.

corinagum
corinagum previously approved these changes Jan 8, 2025
Copy link
Collaborator

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@corinagum corinagum merged commit 3d26bea into microsoft:main Jan 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Teams chef bot sample cannot debug in Test Tool after local debugging
4 participants