-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS] fix: local debug environment variables location in teams chef bot sample #2240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes! Please see comments :)
@aycabas could you take a look? |
The environment variables are loaded in npm script here. |
Nothing major that impacts us in this PR, thanks @corinagum. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
Linked issues
closes: #2241
Details
Provide a list of your changes here. If you are fixing a bug, please provide steps to reproduce the bug.
a. Clone the sample.
b. Select "Debug (Edge)" and press "F5".
c. Stop debugging and Select "Debug in Test Tool".
d. The Test Tool will show authentication error.
Change details
Environment variables like bot id and password will be read from .localConfigs in npm script.
So the env file update in teamsapp.local.yml should be ".localConfigs". Writing to ".env" file will pollute the Test Tool environment.
code snippets:
screenshots:
Attestation Checklist
My code follows the style guidelines of this project
I have checked for/fixed spelling, linting, and other errors
I have commented my code for clarity
I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)
My changes generate no new warnings
I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:
New and existing unit tests pass locally with my changes
Additional information