Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement != operator for filtering #4494

Merged
merged 6 commits into from
Jan 2, 2025
Merged

Implement != operator for filtering #4494

merged 6 commits into from
Jan 2, 2025

Conversation

Youssef1313
Copy link
Member

Fixes #4302

@microsoft-github-policy-service microsoft-github-policy-service bot added the Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library label Jan 2, 2025
@Youssef1313 Youssef1313 marked this pull request as ready for review January 2, 2025 13:22
Evangelink
Evangelink reviewed Jan 2, 2025
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some tests with wildcard and globbing wildcard (**). And maybe a test checking a 'and' and 'or' condition

@Youssef1313
Copy link
Member Author

Can you please add some tests with wildcard and globbing wildcard (**). And maybe a test checking a 'and' and 'or' condition

** is currently broken. This will be fixed by #4495

@Youssef1313
Copy link
Member Author

@Evangelink Now that #4495 is merged, I added extra tests. Let me know if they cover what you had in mind or if there are still more cases to test.

@Evangelink Evangelink merged commit dd0ac32 into microsoft:main Jan 2, 2025
10 checks passed
@Youssef1313 Youssef1313 deleted the implement-not-equal branch January 3, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

@MarcoRossignoli MarcoRossignoli Awaiting requested review from MarcoRossignoli MarcoRossignoli is a code owner

Assignees
No one assigned
Labels
Area: Testing Platform Belongs to the Microsoft.Testing.Platform core library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Microsoft.Testing.Platform: not equal operator not working in mstest runner graph query filtering
2 participants
@Youssef1313 @Evangelink