make some methods static #4564
Merged
make some methods static #4564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonCropp
requested review from
MarcoRossignoli and
Evangelink
as code owners
Youssef1313
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
LGTM, but this is curious. Why the one in MTP product code wasn't flagged by CA1822? The rest are test-only and we disable the rule on tests so that's expected
Line 13 in 9682c1d
@Evangelink Do you see any obvious reason? If not, probably we should track it in an issue for future investigation.
I have seen a couple of analyzers that are not well raised in our repo but never was able to spend much time on it.
We may want to re-enable for the test infra projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.