-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Not Ready] [typespec-vscode] Add codefix for triple quate indent #5458
Open
mzhongl524
wants to merge
7
commits into
microsoft:main
Choose a base branch
from
mzhongl524:add-codefix-for-triple-quate-indent
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Not Ready] [typespec-vscode] Add codefix for triple quate indent #5458
mzhongl524
wants to merge
7
commits into
microsoft:main
from
mzhongl524:add-codefix-for-triple-quate-indent
+213
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzhongl524
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
December 27, 2024 08:05
microsoft-github-policy-service
bot
added
the
compiler:core
Issues for @typespec/compiler
label
Dec 27, 2024
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
You can try these changes here
|
RodgeFu
reviewed
Jan 8, 2025
const startPos = location.pos; | ||
const endPos = location.end; | ||
const offSet = 3; | ||
const splitOrIndentStr = "\r\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the name is confusing, it's not a indent, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #4609
Add codefix for
triple-quote-indent
warning ,and meanwhile add test case for it