[http-client-csharp] the post processor should always keep customized code as root documents #5481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
ArcturusZhang
force-pushed
the
post-processor-should-always-keep-customized-types
branch
from
c4a9678 to
668c68b
Compare
|
API change check API changes are not detected in this pull request. |
…-always-keep-customized-types
ArcturusZhang
commented
Jan 6, 2025
...ent-csharp/generator/Microsoft.Generator.CSharp/src/PostProcessing/GeneratedCodeWorkspace.cs
Show resolved
Hide resolved
live1206
approved these changes
Jan 6, 2025
...ent-csharp/generator/Microsoft.Generator.CSharp/src/PostProcessing/GeneratedCodeWorkspace.cs
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/test/common/Helpers.cs
Outdated
Show resolved
Hide resolved
…rp/src/PostProcessing/GeneratedCodeWorkspace.cs Co-authored-by: Wei Hu <[email protected]>
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/CSharpGen.cs
Show resolved
Hide resolved
I would love to but I did not really figured out a way that we could unit test this. |
JoshLove-msft
approved these changes
Jan 9, 2025
|
@live1206 @JoshLove-msft I opened this issue to track adding test cases for post processor in case we forgot it in the future: #5569 |
ArcturusZhang
deleted the
post-processor-should-always-keep-customized-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5441
Previously in our generator, we have two instances of
GeneratedCodeWorkspace: one for the project that is being generated right now (the generated code project), one for the existing part of the generated library (the customized code project).This leads to an issue that in the post processor, only the generated documents are passed into the post processor, therefore the post processor actually does not know about the existence of the customized files.
This is not very correct because the generated files must need those customized files to work properly therefore they should be in the same project.
This PR refactors this part to change the structure of
GeneratedCodeWorkspace: now we only create one instance ofGeneratedCodeWorkspace, and the project inside it will be initialized with shared files and all the customized files in it.In this way, when we get to the post processor, it should be able to access all the necessary documents.