image support in prompt tsx #136
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justschen
commented
Dec 2, 2024
connor4312
reviewed
Jan 7, 2025
| @@ -191,7 +191,7 @@ suite('PromptRenderer', () => { | |||
| const inst = new PromptRenderer(fakeEndpoint, Prompt1, {}, tokenizer); | |||
There was a problem hiding this comment.
Can you add some tests for your new image element?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DRAFT] first pass!
fix https://github.com/microsoft/vscode-copilot/issues/8955
main thing will be with the new
contenttype inopenai.tswhich makes it not only astringbut also an object. this means in many places (in prompt tsx tests, in copilot extension, etc) we'll have to check that or cast it if we know that it won't be an image.