Navigation: Add a way to “pop” the root on iOS #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugolefrancois
requested review from
npresseault,
sdetilly and
ChristopheTremblay
ChristopheTremblay
approved these changes
May 13, 2024
navigation/ios/Navigation.swift
Outdated
| @@ -28,15 +30,17 @@ private struct NavigationModifier<ScreenData, Route: PilotNavigationRoute, Actio | |||
| buildView: @escaping (ScreenData) -> ScreenView, | |||
| buildNavigation: @escaping ([Route], Route) -> PilotNavigationType<ScreenData, NavModifier>?, | |||
| handleAction: ((Action) -> Void)? = nil, | |||
| navigationManager: PilotNavigationManager<Route, Action>? = nil | |||
| navigationManager: PilotNavigationManager<Route, Action>? = nil, | |||
| popRoot: (() -> Void)? | |||
There was a problem hiding this comment.
Nope, this is called internally, so we always pass something.
npresseault
approved these changes
May 13, 2024
navigation/ios/NavigationState.swift
Outdated
| @@ -23,19 +23,22 @@ class NavigationState< | |||
| private let buildNavigation: (([Route], Route) -> PilotNavigationType<ScreenData, NavModifier>?)? | |||
| private let navigationManager: PilotNavigationManager<Route, Action>? | |||
| private let actionListener: ActionListener<Route, Action> | |||
| private let popRoot: (() -> Void)? | |||
There was a problem hiding this comment.
I agree with the behavior, however I'm not sure about the naming, this feels inconsistant with the handleAction closure. Maybe handlePopRoot if that is a thing?
On android I would've gone for onRootPopped and onAction but whatever feels more natural in the iOS terms is fine with me.
hugolefrancois
force-pushed
the
feature/root_pop_ios
branch
from
5945997 to
cec7d68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality becomes necessary when the Pilot navigation stack is not implemented at the app's root level but is instead utilized within a specific app section. Given that the navigation stack might be integrated within a navigation controller or displayed in a modally, the responsibility to close the stack must be transferred to the caller.
To address this requirement, an optional closure named "popRoot" has been introduced at the navigation's entry point, enabling a flexible approach to close the stack.