Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set navigationDismissTriggered flag when popping by specific route #17

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

renaudpg
Copy link
Contributor

@renaudpg renaudpg commented Jul 4, 2024

Sur iOS, le flag navigationDismissTriggered n'est pas set à true quand une navigation est effectuée via popBy, et aucun délai n'est accordé pour l'animation.

Cela peut empêcher l'affichage d'animations de transition.

  • Attendre le délai d'animation et set le dismiss flag avant d'effectuer la navigation
  • Fix typo

@renaudpg renaudpg requested a review from npresseault July 12, 2024 10:11
@renaudpg renaudpg merged commit 3f78c57 into main Jul 16, 2024
1 check passed
@renaudpg renaudpg deleted the ios-navigation-state-pop-by-set-flag branch July 16, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants