[core] Generate PropTypes from type definitions #16642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
commented
Jul 18, 2019
merceyz
commented
Jul 18, 2019
|
No bundle size changes comparing 2656c6c...3a51fe1 |
merceyz
changed the title
merceyz
commented
Jul 19, 2019
|
@eps1lon Is it possible to stop the CI from testing this PR? |
merceyz
commented
Jul 19, 2019
|
|
||
| export default Avatar; | ||
| export type AvatarProps = SimplifiedPropsOf<Avatar>; |
There was a problem hiding this comment.
SimplifiedPropsOf doesn't include component
There was a problem hiding this comment.
Seems this is true for all props that should have component
// Property 'component' does not exist on type ...
type foo = ButtonProps['component']
You need to include You can skip azure only |
merceyz
changed the title
merceyz
force-pushed
the
proptypes
branch
3 times, most recently
from
a6b4d2b to
f70e3b8
Compare
This comment has been minimized.
This comment has been minimized.
merceyz
commented
Jul 19, 2019
merceyz
commented
Jul 20, 2019
merceyz
force-pushed
the
proptypes
branch
3 times, most recently
from
d8a1dc9 to
64fbc2b
Compare
merceyz
commented
Jul 20, 2019
merceyz
commented
Jul 21, 2019
eps1lon
reviewed
Jul 22, 2019
|
Unsure what to do about props that aren't explicitly used, looking at d2e87bc a lot of the props gets removed |
merceyz
force-pushed
the
proptypes
branch
4 times, most recently
from
99d95dc to
0283e3b
Compare
Co-Authored-By: Sebastian Silbermann <[email protected]>
Co-Authored-By: Sebastian Silbermann <[email protected]>
eps1lon
approved these changes
Aug 5, 2019
|
@merceyz Great job and thanks for sticking with it. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the required infrastructure to generate PropTypes from the TypeScript type definitions using typescript-to-proptypes
Motivation
Documented components