[website] Fix FlashCode position #42139
Conversation
oliviertassinari
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-42139--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Cool! Left a couple of remarks. I'm also touching on these components somewhat significantly at another PR (#38604). Lastly, I wonder if this is really a regression? It sounds too severe as it's non-functional and non-blocking—a bug rings as more reasonable.
oliviertassinari
force-pushed
the
fix-material-ui-line-positions
branch
3 times, most recently
from
2c75661 to
22dc8ed
Compare
oliviertassinari
force-pushed
the
fix-material-ui-line-positions
branch
from
baf4435 to
6d40b5c
Compare
| outline: 0px; | ||
| outline: 0; |
There was a problem hiding this comment.
This is not detected by the stylelint parser, I created an issue for them: hudochenkov/postcss-styled-syntax#31.
oliviertassinari
force-pushed
the
fix-material-ui-line-positions
branch
from
6d40b5c to
94476db
Compare
| @@ -151,7 +145,7 @@ export default function MaterialStyling() { | |||
| } | |||
| React.useEffect(() => { | |||
| if (infoRef.current) { | |||
| infoRef.current.scroll({ top: scrollTo[index], behavior: 'smooth' }); | |||
| infoRef.current.scroll({ top: scrollTo[index] * 0.75 * 16 * 1.5 - 3, behavior: 'smooth' }); | |||
There was a problem hiding this comment.
Where do these magic numbers come from?
There was a problem hiding this comment.
Great point. I have added comments and refactored the logic: 31da76b.
| const endLine = [26, 93, 84]; | ||
| const endLine = [31, 93, 84]; |
There was a problem hiding this comment.
Not covering the right lines.
| transition: all ease 120ms; | ||
|
|
||
| :hover { | ||
| background: #9DA8B7; | ||
| :where([data-mui-color-scheme='dark']) & { |
There was a problem hiding this comment.
Fix stylelint issue
| '&:hover:not(.base--selected)': { | ||
| background: 'var(--Tab-hoverBackground)', | ||
| }, | ||
|
|
There was a problem hiding this comment.
Coding style convention
oliviertassinari
added
the
needs cherry-pick
A quick one I noticed
Before:
After:
Preview: https://deploy-preview-42139--material-ui.netlify.app/