-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: assoc method completion #578
base: main
Are you sure you want to change the base?
feat: assoc method completion #578
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
==========================================
+ Coverage 87.61% 87.88% +0.27%
==========================================
Files 271 273 +2
Lines 31861 32080 +219
==========================================
+ Hits 27914 28193 +279
+ Misses 3947 3887 -60 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. One question
I downgraded the runners from |
This PR refactors how we analyze the context of completions and adds completion of associated methods.
There is some unused code in this PR which I need for adding more completions (like methods and use statements). I didnt add them to this PR yet to make sure it doesnt grow to big.