Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: assoc method completion #578

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

baszalmstra
Copy link
Collaborator

This PR refactors how we analyze the context of completions and adds completion of associated methods.

There is some unused code in this PR which I need for adding more completions (like methods and use statements). I didnt add them to this PR yet to make sure it doesnt grow to big.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 87.86885% with 37 lines in your changes missing coverage. Please review.

Project coverage is 87.88%. Comparing base (3d70e0e) to head (589f672).

Files with missing lines Patch % Lines
...language_server/src/completion/context/analysis.rs 82.02% 16 Missing ⚠️
crates/mun_hir/src/source_analyzer.rs 65.62% 11 Missing ⚠️
crates/mun_hir/src/semantics.rs 50.00% 3 Missing ⚠️
crates/mun_language_server/src/completion/item.rs 0.00% 2 Missing ⚠️
crates/mun_language_server/src/to_lsp.rs 50.00% 2 Missing ⚠️
crates/mun_language_server/src/completion/expr.rs 98.27% 1 Missing ⚠️
...tes/mun_language_server/src/completion/name_ref.rs 93.33% 1 Missing ⚠️
crates/mun_language_server/src/file_structure.rs 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
+ Coverage   87.61%   87.88%   +0.27%     
==========================================
  Files         271      273       +2     
  Lines       31861    32080     +219     
==========================================
+ Hits        27914    28193     +279     
+ Misses       3947     3887      -60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Wodann Wodann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. One question

@baszalmstra
Copy link
Collaborator Author

I downgraded the runners from ubuntu-latest to ubuntu-22.04 because llvm 14 is not available for later versions of ubuntu from the official repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants