Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log docker pull failure to the raw_output logger so it reaches gitea #2610

Closed

Conversation

pcarranza
Copy link

Fixes #2609

@pcarranza pcarranza requested a review from a team as a code owner January 11, 2025 14:49
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.76%. Comparing base (5a80a04) to head (af76bf7).
Report is 153 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2610      +/-   ##
==========================================
+ Coverage   61.56%   68.76%   +7.19%     
==========================================
  Files          53       71      +18     
  Lines        9002    10920    +1918     
==========================================
+ Hits         5542     7509    +1967     
+ Misses       3020     2848     -172     
- Partials      440      563     +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pcarranza
Copy link
Author

I think that it's best to close this one in favor of #2631

As it was correctly pointed out by @ChristopherHX this should be fixed in Gitea - the only change I introduced was increase the logging level when debug is enabled by setting up SetReportCaller and pushing it to the job logger so I can understand where the logging should be happening.

In the end, the fact that this is not percolated in gitea seems to be a specific failure case of act_runner and not act.

Apologies for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Act step using docker silently fails when the image access is forbidden
1 participant