Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial zone_sync values to the ConfigMap #7239

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

AlexFenlon
Copy link
Contributor

Proposed changes

This pr adds the following zone_sync values to the default nginx-config ConfigMap.

  • zone-sync true/false
  • zone-sync-port - int

zone-sync-port requires zone-sync to be enabled, which in turn needs NGINX Plus enabled.

Domain is also added and is written dynamically based on the namespace of the controller eg.
nginx-ingress-headless.nginx-ingress.svc.cluster.local

This PR only just adds the values and the validation for it, the user cannot enter anyhing until future implementation.
Resolves: #7218

apiVersion: v1
kind: ConfigMap
metadata:
  name: nginx-config
  namespace: nginx-ingress
data:
  zone-sync: true
  zone-sync-port: 1234

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner January 29, 2025 14:16
@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code labels Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 62.79070% with 16 lines in your changes missing coverage. Please review.

Project coverage is 52.72%. Comparing base (4dbfc2e) to head (46838e2).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/configs/configmaps.go 62.79% 11 Missing and 5 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7239   +/-   ##
=======================================
  Coverage   52.72%   52.72%           
=======================================
  Files          89       89           
  Lines       20843    20886   +43     
=======================================
+ Hits        10989    11012   +23     
- Misses       9396     9409   +13     
- Partials      458      465    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code
Projects
Status: Todo ☑
Development

Successfully merging this pull request may close these issues.

zone_sync conversion from snippet to ConfigMap values
2 participants