Feature/map #20
Open
Feature/map #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge remote-tracking branch 'origin/master' into feature/map
nhardy
requested changes
Oct 16, 2016
| const myLatLng = {lat: -25.363, lng: 131.044}; | ||
|
|
||
| // Create a map object and specify the DOM element for display. | ||
| this.props.googleMap = new google.maps.Map(this.refs.map, { |
|
|
||
| updateMap = () => { | ||
| const map = this.props.googleMap; | ||
| this.props.posts.map((post) => { |
| } | ||
|
|
||
| updateMap = () => { | ||
| const map = this.props.googleMap; |
| this.props.posts.map((post) => { | ||
| const { latitude, longitude } = post.location; | ||
| const marker = new google.maps.Marker({ | ||
| map: map, |
|
|
||
| componentDidUpdate(prevProps) { | ||
| if (!prevProps.mapsLoaded && this.props.mapsLoaded) this.initMap(this.props.posts); | ||
| if (this.props.posts.length > 0) this.updateMap(); |
There was a problem hiding this comment.
import { isEqual, property } from 'lodash-es';
// ...
if (!isEqual(this.props.posts.map(property('id')), prevProps.posts.map(property('id'))) this.updateMap();| const map = this.props.googleMap; | ||
| this.props.posts.map((post) => { | ||
| const { latitude, longitude } = post.location; | ||
| const marker = new google.maps.Marker({ |
There was a problem hiding this comment.
You probably don't want to keep re-adding points. Think about a way to keep track of existing points, or alternatively clear the map, and re-add.
nhardy
reviewed
Oct 16, 2016
|
|
||
| // Create a map object and specify the DOM element for display. | ||
| this.props.googleMap = new google.maps.Map(this.refs.map, { | ||
| center: myLatLng, |
There was a problem hiding this comment.
Remember, you already have access to the user's location (this.props.location)
There was a problem hiding this comment.
But at this point we don't, it's retrieved afterwards
There was a problem hiding this comment.
Then we should probably have some logic to create the map only once the script has loaded, and we have the user's location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.