Don't let headers contain newlines, fix fn emit_folded() #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hocuri
force-pushed
the
upstream-no-newlines
branch
2 times, most recently
from
e29489a to
7a1f99f
Compare
Hocuri
force-pushed
the
upstream-no-newlines
branch
from
7a1f99f to
304aabf
Compare
The problem was: MIME_LINE_LENGTH is 78. If a line is 78 chars long and ends with a space, then the previous implementation would insert a line break after the space (as the line lenghth of 78 is reached). Then, it would forget about it and go on with the next char, which is the existing line break. Therefore we have two line breaks in a row, i.e. an empty line. The easiest way I found to fix this was, not parse the input character by character but split it using the stdlib and then work with the individual words.
link2xt
reviewed
Jan 12, 2021
| current = word.to_owned(); | ||
| } else { | ||
| if !current.is_empty() { | ||
| current += " "; // Separate the existing line and the new word with a space |
There was a problem hiding this comment.
This will replace tabs and other whitespace in the original string with spaces, is this always correct? Should be ok in most cases I guess, but maybe there are some cases where preserving tabs and not replacing them with spaces is important?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was:
fix #59
@niax can we do this this way, or are we going to get other problems?