Major updates for vinxi-mdx #453
Conversation
Akkuma
commented
Jan 22, 2025
Akkuma
commented
- Latest TS
- Dist no longer needed
- ESM build properly utilized
- Types working
* Latest TS * Dist no longer needed * ESM build properly utilized * Types working
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi! I'm the It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃 |
autofix.ci
| @@ -12,7 +12,7 @@ | |||
| "@mdx-js/react": "^2.3.0", | |||
| "@mdx-js/rollup": "^2.3.0", | |||
| "@picocss/pico": "^1.5.10", | |||
| "@vinxi/plugin-mdx": "3.7.2", | |||
| "@vinxi/plugin-mdx": "workspace:^", | |||
There was a problem hiding this comment.
Utilizes the current workspace rather than a published version
| // @ts-ignore "Property '_resolveFilename' does not exist on type 'typeof Module'." | ||
| Module._resolveFilename(moduleId, { | ||
| id: fromFile, | ||
| filename: fromFile, | ||
| // @ts-ignore "Property '_nodeModulePaths' does not exist on type 'typeof Module'. |
There was a problem hiding this comment.
I'm not familiar enough with what this was trying to do outside of being utilized for openapi docs that was not possible through some other public function
| @@ -1 +1 @@ | |||
| !dist | |||
| dist | |||
There was a problem hiding this comment.
dist is no longer needed
| "exports": { | ||
| ".": { | ||
| "require": "./src/index.ts", | ||
| "import": "./src/index.ts" | ||
| } |
There was a problem hiding this comment.
By not including this esm was never being utilized in environments that support it.
This is changed in prepublishOnly to point at the /dist and then back to /src postpublish
| @@ -31,13 +38,14 @@ | |||
| "vfile": "^5.0.0" | |||
| }, | |||
| "devDependencies": { | |||
| "@mdx-js/mdx": "2.3.0", | |||
| "@mdx-js/mdx": "3.1.0", | |||
There was a problem hiding this comment.
v3 has been around since the end of 2023, so I think it is safe to use the latest.
| "target": "ES2022", | ||
| "module": "NodeNext", | ||
| "lib": ["ES2022"], |
There was a problem hiding this comment.
There's no reason to support ES2015 when anything that old is EOL.
|
