test_runner: avoid unnecessary error creation

nodejs · Jan 15, 2025 · db86232 · db86232
1 parent eadba47
commit db86232
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/lib/internal/test_runner/test.js b/lib/internal/test_runner/test.js
@@ -709,13 +709,16 @@ class Test extends AsyncResource {
       return;
     }
 
-    const cancelledError = this.root.bailed ? new ERR_TEST_FAILURE(
-      'test bailed out',
-      kTestBailedOut,
-    ) : new ERR_TEST_FAILURE(
-      'test did not finish before its parent and was cancelled',
-      kCancelledByParent,
-    );
+    let cancelledError;
+    if (!error) {
+      cancelledError = this.root.bailed ? new ERR_TEST_FAILURE(
+        'test bailed out',
+        kTestBailedOut,
+      ) : new ERR_TEST_FAILURE(
+        'test did not finish before its parent and was cancelled',
+        kCancelledByParent,
+      );
+    }
 
     this.fail(error || cancelledError);
     this.cancelled = true;
@@ -773,8 +776,6 @@ class Test extends AsyncResource {
 
     if (this.bail && !this.root.bailed) {
       this.root.bailed = true;
-      this.bailed = true;
-      this.endTime ??= hrtime();
       this.root.postRun();
     }
   }