Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable bundle.optimizeTranslationDirective #3256

Conversation

BobbieGoede
Copy link
Collaborator

@BobbieGoede BobbieGoede commented Dec 5, 2024

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

It's more of a fix than a feature, since this gives users a workaround for #3241. Since we're deprecating v-t in future versions anyway (intlify/vue-i18n#2045) this will allow users to opt out of its optimization.

Checking whether the compiler is present will be a more complete (no user action required) fix (intlify/bundle-tools#421) as it's currently breaking the reproduction/start template as well.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede self-assigned this Dec 5, 2024
Copy link

pkg-pr-new bot commented Dec 5, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@nuxtjs/i18n@3256

commit: d66eef4

@BobbieGoede BobbieGoede requested a review from kazupon December 5, 2024 14:06
Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good for me!

@BobbieGoede BobbieGoede merged commit 1b4574f into nuxt-modules:main Dec 6, 2024
10 checks passed
@BobbieGoede BobbieGoede deleted the feat/configurable-bundle-directive-optimization branch December 6, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants