Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor position validity #779

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Anchor position validity #779

wants to merge 11 commits into from

Conversation

jamesnw
Copy link
Contributor

@jamesnw jamesnw commented Jan 9, 2025

Description

My goal for this article is to be a resource that can be used when someone's anchor isn't being found.

Related Issue(s)

#778

https://deploy-preview-779--oddleventy.netlify.app/2025/01/15/anchor-position-validity/

Questions for review:

  • Are there visuals that could help make it clearer?
  • Are the CodePens clear enough?
  • Are things accurate?

Copy link

github-actions bot commented Jan 9, 2025

View diff of compiled files (may take a few minutes): https://github.com/oddbird/oddleventy-built/compare/main..anchor-valid

@jamesnw jamesnw changed the title Anchor positiion validity Anchor position validity Jan 15, 2025
* main:
  upgrade yarn
  Bump the npm-minor-upgrades group across 1 directory with 9 updates
  Bump @11ty/eleventy-img in the npm-major-upgrades group
  Automated webmentions update
Copy link
Member

@jgerigmeyer jgerigmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesnw Great article! I pushed some minor copy edits because that was quicker than submitting them individually as PR comments, but feel free to revert any of them.

content/blog/2025/anchor-position-validity.md Outdated Show resolved Hide resolved
content/blog/2025/anchor-position-validity.md Outdated Show resolved Hide resolved
content/blog/2025/anchor-position-validity.md Outdated Show resolved Hide resolved
content/blog/2025/anchor-position-validity.md Outdated Show resolved Hide resolved
content/blog/2025/anchor-position-validity.md Outdated Show resolved Hide resolved
content/blog/2025/anchor-position-validity.md Outdated Show resolved Hide resolved
@jgerigmeyer jgerigmeyer removed their assignment Jan 16, 2025
Copy link
Member

@stacyk stacyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesnw I think this is a great explainer! I started my review yesterday after standup and see some things have already changed. I will submit this as is and go back through it. I find the demos very helpful, and wonder if there is a reason (other than time) why we wouldn't include a Top Layer demo and anchor scope one.

content/blog/2025/anchor-position-validity.md Outdated Show resolved Hide resolved
content/blog/2025/anchor-position-validity.md Show resolved Hide resolved
content/blog/2025/anchor-position-validity.md Outdated Show resolved Hide resolved
content/blog/2025/anchor-position-validity.md Outdated Show resolved Hide resolved
content/blog/2025/anchor-position-validity.md Outdated Show resolved Hide resolved
content/blog/2025/anchor-position-validity.md Outdated Show resolved Hide resolved
exhaustive, and omits some cases with hidden content, fixed position anchors,
and other less likely edge cases.

We're also available for office hours to help work through your specific case.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should include a link here too, but is it a different one that the reporting an item not on our list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's the same one, but I think it makes sense to have it in both places.

@SondraE We could update this to point to an office hours page if one exists eventually.

content/blog/2025/anchor-position-validity.md Outdated Show resolved Hide resolved
content/blog/2025/anchor-position-validity.md Outdated Show resolved Hide resolved
content/blog/2025/anchor-position-validity.md Show resolved Hide resolved
@stacyk stacyk assigned jamesnw and unassigned stacyk Jan 16, 2025
@jamesnw jamesnw requested review from jgerigmeyer and stacyk January 19, 2025 18:10
@jamesnw
Copy link
Contributor Author

jamesnw commented Jan 20, 2025

I find the demos very helpful, and wonder if there is a reason (other than time) why we wouldn't include a Top Layer demo and anchor scope one.

@stacyk I added demos for anchor scope and top layer. I was avoiding top layer because I suspect there's an issue with the spec, so I elaborated on what is working a bit.

* main:
  update yarn.lock
  Bump the npm-minor-upgrades group with 5 updates
  Automated webmentions update
content/blog/2025/anchor-position-validity.md Outdated Show resolved Hide resolved
content/blog/2025/anchor-position-validity.md Outdated Show resolved Hide resolved
content/blog/2025/anchor-position-validity.md Outdated Show resolved Hide resolved
Co-authored-by: Jonny Gerig Meyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants