vendor:raylib: add options to link with raylib/raygui from system #4619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingerBill
reviewed
Jan 1, 2025
Comment on lines
+8
to
+11
| when RAYGUI_SYSTEM { | ||
| foreign import lib "system:raygui" | ||
| } else when ODIN_OS == .Windows { |
There was a problem hiding this comment.
RAYLIB_SYSTEM and RAYGUI_SYSTEM allow building in some systems that wouldn't accept bundled libraries like Nix. If you don't enable them on Windows it should just use the bundled libraries.
spitulax
force-pushed
the
raylib-system
branch
from
2608cd2 to
5759040
Compare
Arsalan2356
added a commit
to Arsalan2356/dotfiles
that referenced
this pull request
Jan 3, 2025
Add nixpkgs-master to flake inputs Rename test branch to custom Add odin with a patch to use raylib from the system (can remove patch if odin pr closes (odin-lang/Odin#4619)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Odin ships the libraries for raylib and raygui and links to them when using their bindings from vendor. But this does not play well with Nix, presumably because the libraries are not compiled for Nix.This is the issue with the way Odin passes library paths to the linker. I made a PR addressing this issue in #4719. With this, compiling with the vendored library should be fine, but you have to fiddle with dependencies like libX11 or glfw to get the program actually running.
To alternatively use
vendor:raylibon Nix, you have to also compile the libraries for Nix and link with it.This added options to link the libraries from system instead of the libraries shipped into the compiler.
This is easier to set up with Nix, because adding the
raylibpackage from nixpkgs tobuildInputsautomatically adds some dependencies.