[IMP] marketing: match the Display Timezone description with tooltips #11596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
community PR: odoo/odoo#190867 |
This was referenced Dec 17, 2024
|
Followup of the discussion of the first proposition: odoo/odoo#189363 |
reth-odoo
reviewed
Jan 8, 2025
StraubCreative
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Hi @lase-odoo
Thank you for these updates. I see these are proactive edits in line with a UI change we're looking to make on /odoo.
I have two small markup improvements which I'll push up in just a moment!
| @@ -43,8 +43,8 @@ Odoo database or by creating and editing new field data. Key information to ente | |||
| includes: | |||
|
|
|||
| - :guilabel:`Event Name`: give the event a title. | |||
| - :guilabel:`Date`: includes the start and end dates/times for the event. | |||
| - :guilabel:`Timezone`: covers the timezone for when the event is taking place. | |||
| - :guilabel:`Date`: when the event is scheduled to take place (expressed in your local timezone on the form view). | |||
There was a problem hiding this comment.
Line exceeds 100 characters
Suggested change
| - :guilabel:`Date`: when the event is scheduled to take place (expressed in your local timezone on the form view). | |
| - :guilabel:`Date`: when the event is scheduled to take place (expressed in your local timezone on | |
| the form view). |
| - :guilabel:`Date`: includes the start and end dates/times for the event. | ||
| - :guilabel:`Timezone`: covers the timezone for when the event is taking place. | ||
| - :guilabel:`Date`: when the event is scheduled to take place (expressed in your local timezone on the form view). | ||
| - :guilabel:`Display Timezone`: indicates the timezone in which the event dates/times will be displayed on the website.. |
There was a problem hiding this comment.
Similar feedback above (character count), remove extra period.
Suggested change
| - :guilabel:`Display Timezone`: indicates the timezone in which the event dates/times will be displayed on the website.. | |
| - :guilabel:`Display Timezone`: indicates the timezone in which the event dates/times will be | |
| displayed on the website. |
Issue: The current descriptions and naming of the `Date` fields (`date_begin`, `date_end`) and the `Timezone` field (`date_tz`) can be confusing in the form view of the event model. Specifically: The timezone used for converting the form dates to the database is determined by the context and not by the `Timezone` field present on the form. However, this `Timezone` field determines the timezone used for displaying the event's date/time on the website. This change clarifies the situation according to the update done in the community PR opw-4323142
StraubCreative
force-pushed
the
16.0-opw-4323142-display_timezone_event_form-lase
branch
from
35b049f to
e8793e1
Compare
|
RST updates applied on e8793e1. @lase-odoo do we want to merge this in right away or wait for other PRs to close first (they don't appear to be linked)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The current descriptions and naming of the
Datefields (date_begin,date_end) and theTimezonefield (date_tz) can be confusing in the form view of the event model. Specifically:The timezone used for converting the form dates to the database is determined by the context and not by the
Timezonefield present on the form. However, thisTimezonefield determines the timezone used for displaying the event's date/time on the website. This change clarifies the situation according to the update done in the community PRopw-4323142