Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Helpdesk: Update SLAs #11691

Closed
wants to merge 1 commit into from
Closed

[IMP] Helpdesk: Update SLAs #11691

wants to merge 1 commit into from

Conversation

jero-odoo
Copy link
Contributor

Updated SLAs doc for V18. Updated images and content.
(Note: there is currently a bug in the bar graph that causes incorrect column headings to appear. Until that bug is worked out, those images have not been updated)

@jero-odoo jero-odoo added the 2 label Jan 2, 2025
@jero-odoo jero-odoo self-assigned this Jan 2, 2025
@robodoo
Copy link
Collaborator

robodoo commented Jan 2, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team January 2, 2025 19:49
@jero-odoo
Copy link
Contributor Author

hey @dikd-odoo this is ready for review. Thanks!

Copy link
Contributor

@dikd-odoo dikd-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo great work on this documentation update! I've finished my review with some edits that require your attention. Particularly I was wondering about the |SLA| command and how it builds out as "SLAs" only (plural), which is not always grammatically correct, depending on the context. Once you've taken care of that and looked at the other suggestions, feel free to move this to final review. Thank you!

content/applications/services/helpdesk/overview/sla.rst Outdated Show resolved Hide resolved
content/applications/services/helpdesk/overview/sla.rst Outdated Show resolved Hide resolved
content/applications/services/helpdesk/overview/sla.rst Outdated Show resolved Hide resolved
content/applications/services/helpdesk/overview/sla.rst Outdated Show resolved Hide resolved
content/applications/services/helpdesk/overview/sla.rst Outdated Show resolved Hide resolved
content/applications/services/helpdesk/overview/sla.rst Outdated Show resolved Hide resolved
content/applications/services/helpdesk/overview/sla.rst Outdated Show resolved Hide resolved
content/applications/services/helpdesk/overview/sla.rst Outdated Show resolved Hide resolved
@jero-odoo jero-odoo force-pushed the 18.0-helpdesk-slas-jero branch from 7cac893 to 1484533 Compare January 3, 2025 16:14
@jero-odoo
Copy link
Contributor Author

Thanks Dina!
this is ready for final @Felicious

@jero-odoo jero-odoo requested a review from a team January 3, 2025 16:29
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo

Amazing job on this comprehensive doc! Your explanations are so clear, and your deep understanding of how the app is meant to be used really shines through—it’s a testament to your experience! 😊

I added a few minor rewording suggestions to help clarify the context for users who might not be as familiar with support teams and Helpdesk. Feel free to disregard them if they don’t fit or aren’t helpful. Keep up the fantastic work! 🙌

@jero-odoo jero-odoo force-pushed the 18.0-helpdesk-slas-jero branch from 1484533 to c99cd69 Compare January 8, 2025 13:55
@jero-odoo jero-odoo added the 18.0 label Jan 8, 2025
@jero-odoo
Copy link
Contributor Author

Thank you Felicia!
@samueljlieber this is ready for tech review.

@jero-odoo jero-odoo requested a review from a team January 8, 2025 16:44
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo, nice work on this PR 👍 Approving with two quick comments!
..
@robodoo delegate=jero-odoo

@jero-odoo jero-odoo force-pushed the 18.0-helpdesk-slas-jero branch from c99cd69 to dd2201b Compare January 9, 2025 18:37
@jero-odoo
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request Jan 9, 2025
closes #11691

Signed-off-by: Jessica Rogers (jero) <[email protected]>
Co-authored-by: dikd-odoo <[email protected]>
robodoo pushed a commit that referenced this pull request Jan 9, 2025
closes #11691

Signed-off-by: Jessica Rogers (jero) <[email protected]>
Co-authored-by: dikd-odoo <[email protected]>
robodoo pushed a commit that referenced this pull request Jan 9, 2025
closes #11691

Signed-off-by: Jessica Rogers (jero) <[email protected]>
Co-authored-by: dikd-odoo <[email protected]>
@robodoo
Copy link
Collaborator

robodoo commented Jan 10, 2025

@jero-odoo staging failed: ci/l10n on c28db857c04d717bc7afef265405af1fd814078a (view more at https://runbot.odoo.com/runbot/build/73137330)

@jero-odoo
Copy link
Contributor Author

@robodoo retry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants