-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] charts: allow to invert columns/rows #5480
base: master
Are you sure you want to change the base?
Conversation
73cd6de
to
fee0aea
Compare
Task Description This task add the possibility for the user to invert the columns and rows of a chart dataset. Related Task Task: 3693182
fee0aea
to
94ec3fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋
src/components/side_panel/chart/building_blocks/generic_side_panel/config_panel.ts
Show resolved
Hide resolved
@@ -13,6 +13,15 @@ | |||
onSelectionConfirmed="() => this.onDataSeriesConfirmed()" | |||
hasSingleRange="true" | |||
/> | |||
<Section class="'pt-0'"> | |||
<Checkbox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be a button rather than a checkbox ? The option definition.switchAxes
does nothing at all except give the state of this checkbox if I'm not mistaken. Either this sould be a steteless button that transposes everyhing, either there should be no logic in the panel, and the option definition.switchAxes
should have an effect when creating the datastes/runtime.
Here we could 1) activate the checkbox to transpose every column into a row 2) remove all the dataset 3) add the original column datasets. Now we have columns datasets with the option switchAxes enabled, and the checkbox dataSetsHaveTitleLabel with the wrong label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A button won't be enough as we need some state (and visual indication) to know if we want to treat the data as row or as column. Maybe we can make something to switch the dataset when hitting "confirm" in case the "switch axes" checkbox is checked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing is, we don't treat the data as row when the checkbox is checked. Nothing change in the way we handle the ranges given. AFter clicking the button, we can still add column datasets and mix them with the row dataset. Or delete the rows datasets. Or add rows datasets manually without clicking on the checkobx beforehand. So it's really not a stateful thing ATM.
Task Description
This task add the possibility for the user to invert the columns and rows of a chart dataset.
Related Task