Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] runbot: add a widget for pull requests url's #1009

Open
wants to merge 2 commits into
base: 18.0
Choose a base branch
from

Conversation

d-fence
Copy link
Contributor

@d-fence d-fence commented Dec 6, 2024

While it's useful to have a clickable link to the fixing pull request on the runbot error list, we cannot display the entire url as it takes too much space. So a static text View PR is used.

As this static text is of limited use, this commit adds a new widget that displays a shortened URL for the github pull request only showing the repo and the PR number.

@C3POdoo C3POdoo requested a review from a team December 6, 2024 11:08
@d-fence d-fence requested a review from Xavier-Do December 6, 2024 12:22
d-fence and others added 2 commits December 23, 2024 10:40
While it's useful to have a clickable link to the fixing pull request
on the runbot error list, we cannot display the entire url as it takes
too much space. So a static text `View PR` is used.

As this static text is of limited use, this commit adds a new widget
that displays a shortened URL for the github pull request only showing
the repo and the PR number.
@d-fence d-fence force-pushed the 17.0-runbot-pr-widget-moc branch from dea41d9 to 30124cf Compare December 23, 2024 09:40
@d-fence d-fence changed the base branch from 17.0 to 18.0 December 23, 2024 09:41
Copy link
Contributor

@Williambraecky Williambraecky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants