Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make loop for smallest_dimension_yet inclusive #12

Conversation

tertsdiepraam
Copy link

Closes #11

Hi! Thanks for this great library! Like I mentioned in the issue, we would love to upgrade to a later version, but this is blocking us, so I thought I would implement it in a PR. It contains exactly the change in the issue.

@mtsoltan
Copy link

mtsoltan commented Oct 2, 2021

This is necessary, please merge it.

@sylvestre
Copy link

@ogham
would you be ok to merge it? thanks

@sylvestre
Copy link

@behnam @ogham seems to be MIA. Is that something you could help with? thanks

@tertsdiepraam
Copy link
Author

uutils and eza are both using uutils-term-grid now, an actively maintained fork of this library. Many thanks to @ogham for creating an awesome library we can build upon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in smallest_diminesions_yet calculation?
3 participants