chore: Enable field alignment go vet check #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patricia Reinoso <[email protected]>
|
Can one of the admins verify this patch? |
fix typo
|
@gab-arrobo can you please review this. |
Will do |
gab-arrobo
reviewed
Jan 26, 2024
gab-arrobo
reviewed
Jan 27, 2024
gnodeb/context/gnbupf.go
Outdated
| @@ -18,8 +18,7 @@ const GTP_U_PORT int = 2152 | |||
|
|
|||
| // GnbUpf holds the UPF context | |||
| type GnbUpf struct { | |||
| UpfAddr *net.UDPAddr | |||
| UpfIpString string | |||
| UpfAddr *net.UDPAddr | |||
There was a problem hiding this comment.
Something similar to my previous comment, why not putting variables of the same type together? For example:
UpfAddr *net.UDPAddr
GnbUpUes *GnbUeDao
Log *logrus.EntrySigned-off-by: Patricia Reinoso <[email protected]>
I am always eager to remove unnecessary comments. I moved all the log fields next to other pointers |
|
@patriciareinoso, please resolve conflicts. Thanks! |
Signed-off-by: Patricia Reinoso <[email protected]>
gab-arrobo
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go vet checks were enabled in #116
(but they were disable in following commits)
This PR re enables all go vet analyzers and fixes
fieldalignmentanalyzer