Enable more ruff checks and fix #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdewar
requested review from
AdrianDAlessandro,
Thomas-Rowlands,
tb143 and
jmp111
|
Just getting some errors running the regression test on Python 3.10.0, relating to the fuzzywuzzy module, what Python version are you running? |
alexdewar
force-pushed
the
ruff-config
branch
from
79dfb9b to
f9889d7
Compare
|
@Thomas-Rowlands I'm also running Python 3.10 and I managed to reproduce your error. I've no idea what was causing it, but when I deleted my virtual environment and started over by running Could you try that? The regression test is passing on the CI which suggests that it should work with a clean virtual environment. |
Thomas-Rowlands
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't realise when we merged #58 that there was no
ruffconfiguration specified inpyproject.toml, so we were just using the default one.I've copied over the config we normally use from our Python template and have fixed all warnings. I didn't include the
pydocstylechecks because of #49, but these could be added later. I also enabled thepylintchecks, which fixes bogus escape sequences, thus fixing #54.Fixes #54.