Revert "[processorhelper] deprecating unused methods" #11114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3f9bc53.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11114 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 414 414
Lines 19810 19810
=======================================
Hits 18271 18271
Misses 1167 1167
Partials 372 372 ☔ View full report in Codecov by Sentry. |
|
After discussing with @codeboten and @mx-psi, we agreed that the associated "accepted", "refused", and "dropped" metrics will also be deprecated. |
djaglowski
deleted the
revert-11083-codeboten/deprecate-unused-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #11083
I'd like to propose that these metrics not be deprecated unless
Accepted,Refused, andDroppedare also deprecated. These four metrics describe a complete picture of telemetry flowing through processors.Personally I'd like to deprecate all four in favor of #10708 because the latter can be captured automatically.