[chore] tweak junit.xml upload #12001
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12001 +/- ##
==========================================
+ Coverage 91.62% 91.67% +0.05%
==========================================
Files 447 455 +8
Lines 23739 24038 +299
==========================================
+ Hits 21751 22037 +286
- Misses 1613 1629 +16
+ Partials 375 372 -3 ☔ View full report in Codecov by Sentry. |
.github/workflows/build-and-test.yml
Outdated
| @@ -141,15 +141,16 @@ jobs: | |||
| unittest-matrix: | |||
| strategy: | |||
| matrix: | |||
| runner: [ubuntu-latest] | |||
There was a problem hiding this comment.
i use matrix.os later on - and we use matrix.os in other files. I chose to align the different files.
It needs the |
songy23
added
ci-cd
.github/workflows/build-and-test.yml
Outdated
| - name: Run Unit Tests | ||
| run: | | ||
| make -j4 gotest-with-junit | ||
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: test-results-${{ runner.os }}-${{ matrix.runner }}-${{ matrix.go-version }} | ||
| name: test-results_${{ runner.os }}_${{ matrix.os }}_${{ runner.arch }}_${{ steps.setup-go.outputs.go-version }} |
There was a problem hiding this comment.
wont this result in duplicated os name in the name string?
There was a problem hiding this comment.
Sort of - not quite. Here's what the artifacts look like -
test-results_Linux_ubuntu-latest_X64_1.22.10
so the runner.os is Linux, Macos, etc, and the matrix.os is what we use to request a runner - so ubuntu-latest in this particular example. I captured both since technically one day we may test against different Linux distros
There was a problem hiding this comment.
I changed my mind. If we ever want to do this we can - for now I eliminated the matrix.os variable for simplicity. Plus the information is pretty duplicated and unspecific
Description
This PR tweaks the output junit test files introduced in #11963.
It introduces underscores as a delimiter, adds the architecture to name, and add test file outputs to arm and windows builds.
Testing
Hopefully just these unit tests. For some reason, the arm tests aren't running, and I'm not sure why.