Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Support logs in scrapercontroller #12056

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sincejune
Copy link
Contributor

Description

This PR added support for logs in scraper/scrapercontroller:

  • Add properties in controller for logs.
  • Renamed AddScraper to AddMetricsScraper cuz it receives a scraper.Metrics as input.
  • Renamed NewScraperControllerReceiver to NewMetricsScraperControllerReceiver cuz it receives a consumer.Metrics as input.

Note:

Add @bogdandrutu to this thread as well.

Link to tracking issue

Relevant to #12038

Testing

Added

Documentation

n/a. Adding [chore] to this PR cuz this is only the first part of the change.

@sincejune sincejune requested a review from a team as a code owner January 8, 2025 14:59
@sincejune sincejune requested a review from TylerHelmuth January 8, 2025 14:59
@sincejune sincejune changed the title [chore]Support logs in scrapercontroller [chore] Support logs in scrapercontroller Jan 8, 2025
@sincejune sincejune force-pushed the support-logs-in-scrapercontroller branch from dc55506 to 2c99924 Compare January 9, 2025 13:08
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 91.39785% with 8 lines in your changes missing coverage. Please review.

Project coverage is 91.66%. Comparing base (3132112) to head (ac90903).

Files with missing lines Patch % Lines
scraper/scraperhelper/scrapercontroller.go 91.20% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12056      +/-   ##
==========================================
- Coverage   91.67%   91.66%   -0.01%     
==========================================
  Files         455      455              
  Lines       24038    24108      +70     
==========================================
+ Hits        22037    22099      +62     
- Misses       1629     1634       +5     
- Partials      372      375       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant