Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Upgrade cmake #3167

Merged
merged 3 commits into from
Dec 2, 2024
Merged

[BUILD] Upgrade cmake #3167

merged 3 commits into from
Dec 2, 2024

Conversation

owent
Copy link
Member

@owent owent commented Nov 25, 2024

Fixes #3166

Changes

Please provide a brief description of the changes here.

  • Upgrade the minimal requirement of cmake.
  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team as a code owner November 25, 2024 03:42
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 3f4c133
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/674d280bbd4b220008979dba

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.84%. Comparing base (d15da3b) to head (3f4c133).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3167      +/-   ##
==========================================
- Coverage   87.86%   87.84%   -0.01%     
==========================================
  Files         195      195              
  Lines        6151     6151              
==========================================
- Hits         5404     5403       -1     
- Misses        747      748       +1     

see 1 file with indirect coverage changes

CMakeLists.txt Outdated Show resolved Hide resolved
Downgrade cmake minimal requirement

Add some policy settings to cmake
@owent owent changed the title [Draft] Upgrade cmake Upgrade cmake Nov 27, 2024
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff changed the title Upgrade cmake [BUILD] Upgrade cmake Dec 2, 2024
@marcalff marcalff merged commit fb6fde8 into open-telemetry:main Dec 2, 2024
57 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Dec 2, 2024
@owent owent deleted the upgrade_cmake branch December 12, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CMake] Upgrade cmake_minimum_required to 3.10
3 participants