remove incorrect null suppressions #6075
Conversation
github-actions
bot
added
documentation
| @@ -13,16 +13,16 @@ | |||
| var appBuilder = WebApplication.CreateBuilder(args); | |||
|
|
|||
| // Note: Switch between Zipkin/OTLP/Console by setting UseTracingExporter in appsettings.json. | |||
| var tracingExporter = appBuilder.Configuration.GetValue("UseTracingExporter", defaultValue: "console")!.ToLowerInvariant(); | |||
There was a problem hiding this comment.
Hi @SimonCropp, if you can include your justification for why these are incorrect, that will make the code review much easier. Otherwise our reviews need to do more work to individually verify each of these statements.
For example; This looks safe to remove because by supplying a defaultValue, this method will never return null.
There was a problem hiding this comment.
the IDE highlights them as redudnant, since it know the nullability in each case, and i double checked each of them. are there any you think need more justification
There was a problem hiding this comment.
What IDE or plugin are you using? I'm not seeing the same highlights in Visual Studio but I would like to.
There was a problem hiding this comment.
@TimothyMothra Rider. but you would get the same using R#
Fixes #
Design discussion issue #
Changes
remove incorrect null suppressions that are not possible at runtime
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes