Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant ?? string.Empty in GetSampler #6078

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

remove redundant ?? string.Empty in GetSampler #6078

wants to merge 4 commits into from
+1 −1

Conversation

SimonCropp
Copy link
Contributor

Fixes #
Design discussion issue #

Changes

cant be null since inside a

if (configuration.TryGetStringValue(TracesSamplerConfigKey, out var configValue))

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@SimonCropp SimonCropp requested a review from a team as a code owner January 20, 2025 12:04
@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Jan 20, 2025
@SimonCropp
Copy link
Contributor Author

relies on #6090 being merged first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

Assignees
No one assigned
Labels
pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonCropp @rajkumar-rangaraj