Basic setup for the project #1
Conversation
|
FYI I'm not part of go-compile-instrumentation-maintainers but I could still merge this (i.e. I can see the green button to merge but I don't have access to settings). Just wanted to make sure permissions are set appropriately. |
I want to confirm what permissions should be set? |
Co-authored-by: Przemyslaw Delewski <[email protected]>
Co-authored-by: Przemyslaw Delewski <[email protected]>
Co-authored-by: Przemyslaw Delewski <[email protected]>
|
In terms of permissions to be set, this is documented in https://github.com/open-telemetry/community/blob/main/docs/how-to-configure-new-repository.md However, this should've normally been set by whoever created the repo and maintainers don't normally have admin permissions (unless requested, and with the condition of documenting changes to settings) |
|
@danielgblanco i have updated the repo settings (branch rules were missing) . Can you please check if u still have access to merge |
|
I do not (as expected) :) thanks! |
There was a problem hiding this comment.
Let's get this merged first #2 according the process https://github.com/open-telemetry/community/blob/main/docs/how-to-configure-new-repository.md#codeowners.
Everything looks in good shape now. @open-telemetry/go-compile-instrumentation-approvers Would you please kindly help to review this pull request? |
| git push <YOUR_FORK> <YOUR_BRANCH_NAME> | ||
| ``` | ||
|
|
||
| Open a pull request against the main `opentelemetry-go` repo. Be sure to add the pull |
There was a problem hiding this comment.
| Open a pull request against the main `opentelemetry-go` repo. Be sure to add the pull | |
| Open a pull request against the main `opentelemetry-go-compile-instrumentation` repo. Be sure to add the pull |
| The go compile instrumentation SIG meets regularly. See the | ||
| OpenTelemetry | ||
| [community](https://github.com/open-telemetry/community?tab=readme-ov-file#implementation-sigs) | ||
| repo for information on this and other language SIGs. |
There was a problem hiding this comment.
| repo for information on this and other language SIGs. | |
| repo for information on this and other SIGs. |
This pull request including initial version of: