Update the rolldice example
#1566
Open
+949
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
force-pushed
the
rolldice-example-update
branch
from
c25900c to
cbd61a3
Compare
RonFed
reviewed
Jan 9, 2025
Comment on lines
+51
to
+53
| The `frontend` service has been manually instrumented. | ||
| It does not use the OpenTelemetry Go auto-instrumentation to generate spans. | ||
| It does so by directly using the OpenTelemetry API, SDK, and pre-built instrumentation packages. |
There was a problem hiding this comment.
Maybe we should also auto-instrument the frontend service instead of manually instrumenting it?
I guess it has a value in showing the differences but since we want to emphasize the automatic aspects and not confuse maybe worth to consider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #236
This adapts the example found in https://github.com/MrAlias/otel-auto-demo into our current
rolldiceexample.This change highlights ...
otelglobal API and hybrid instrumentation