add test for SdkTracerProviderUtil.setScopeConfigurator

open-telemetry · Jan 23, 2025 · 16a8248 · 16a8248
1 parent 01a26f6
commit 16a8248
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/internal/SdkTracerProviderUtil.java b/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/internal/SdkTracerProviderUtil.java
@@ -27,7 +27,7 @@ private SdkTracerProviderUtil() {}
 
   /** Reflectively set the {@link ScopeConfigurator} to the {@link SdkTracerProvider}. */
   public static void setScopeConfigurator(
-      SdkTracerProviderBuilder sdkTracerProvider,
+      SdkTracerProvider sdkTracerProvider,
       ScopeConfigurator<TracerConfig> scopeConfigurator) {
     try {
       Method method =

diff --git a/sdk/trace/src/test/java/io/opentelemetry/sdk/trace/SdkTracerProviderTest.java b/sdk/trace/src/test/java/io/opentelemetry/sdk/trace/SdkTracerProviderTest.java
@@ -20,6 +20,7 @@
 import io.opentelemetry.sdk.common.InstrumentationScopeInfo;
 import io.opentelemetry.sdk.internal.ScopeConfigurator;
 import io.opentelemetry.sdk.resources.Resource;
+import io.opentelemetry.sdk.trace.internal.SdkTracerProviderUtil;
 import io.opentelemetry.sdk.trace.internal.TracerConfig;
 import io.opentelemetry.sdk.trace.samplers.Sampler;
 import java.util.function.Supplier;
@@ -187,7 +188,16 @@ void propagatesInstrumentationScopeInfoToTracer() {
   }
 
   @Test
-  void propagatesEnablementToTracer() {
+  void propagatesEnablementToTracerDirectly() {
+    propagatesEnablementToTracer(true);
+  }
+
+  @Test
+  void propagatesEnablementToTracerByUtil() {
+    propagatesEnablementToTracer(false);
+  }
+
+  void propagatesEnablementToTracer(boolean directly) {
     SdkTracer tracer = (SdkTracer) tracerFactory.get("test");
     boolean isEnabled = tracer.isEnabled();
     ScopeConfigurator<TracerConfig> flipConfigurator =
@@ -198,7 +208,11 @@ public TracerConfig apply(InstrumentationScopeInfo scopeInfo) {
           }
         };
     // all in the same thread, so should see enablement change immediately
-    tracerFactory.setScopeConfigurator(flipConfigurator);
+    if (directly) {
+      tracerFactory.setScopeConfigurator(flipConfigurator);
+    } else {
+      SdkTracerProviderUtil.setScopeConfigurator(tracerFactory, flipConfigurator);
+    }
     assertThat(tracer.isEnabled()).isEqualTo(!isEnabled);
   }