SQLAlchemy: db.statement inclusion of sqlcomment as opt-in #3112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
cc'ing @alexmojaki , feel free to comment/review! |
shalevr
reviewed
Dec 18, 2024
...ntelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/engine.py
Outdated
Show resolved
Hide resolved
shalevr
reviewed
Dec 18, 2024
...ntelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/engine.py
Show resolved
Hide resolved
emdneto
reviewed
Dec 20, 2024
...elemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/__init__.py
Outdated
Show resolved
Hide resolved
emdneto
reviewed
Dec 20, 2024
...ntelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/engine.py
Show resolved
Hide resolved
lzchen
reviewed
Dec 20, 2024
...elemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Dec 20, 2024
...elemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Dec 20, 2024
...elemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Dec 20, 2024
...ntelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/engine.py
Show resolved
Hide resolved
…pentelemetry/instrumentation/sqlalchemy/__init__.py Co-authored-by: Leighton Chen <[email protected]>
…pentelemetry/instrumentation/sqlalchemy/__init__.py Co-authored-by: Leighton Chen <[email protected]>
|
@lzchen , @xrmx : regarding this comment: Would it be all right if we worked on getting this particular PR merged first (plus #3115 and #3121) to stop this feature from being On all the time in the next release? |
emdneto
approved these changes
Jan 9, 2025
lzchen
approved these changes
Jan 9, 2025
xrmx
pushed a commit
to xrmx/opentelemetry-python-contrib
that referenced
this pull request
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supports new, optional kwarg
enable_attribute_commenterat SQLAlchemy instrumentation to opt intodb.statementspan attribute inclusion of sqlcomment.Partially addresses #3107
Type of change
Breaking because
db.statementspan attribute inclusion of sqlcomment currently always happens if sqlcommenter enabled. It'll be opt-in with this update, so might break for those users relying on the feature introduced in 0.50b0.How Has This Been Tested?
tox -e py312-test-instrumentation-sqlalchemy-0tox -e py312-test-instrumentation-sqlalchemy-1tox -e py312-test-instrumentation-sqlalchemy-2enable_attribute_commenter=Truevs unsetDoes This PR Require a Core Repo Change?
Checklist: