Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: A Dev Feature for Naming Convention used in Windows Performance Counters #2527

Open
anujnegi270 opened this issue Jan 17, 2025 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@anujnegi270
Copy link

Related Problems?

Our team is an early adopter of OpenTelemetry Rust for ingesting metrics, but we face challenges when dealing with Windows Performance Counters (PerfC) due to differences in naming conventions between OpenTelemetry and PerfC. Specifically, performance counters like \Processor Information(_Total)\% Processor Time (just an example) cannot be directly sent using OpenTelemetry because its naming structure doesn't align with OpenTelemetry’s expected format.

What component are you working with?

opentelemetry-user-events-metrics, N/A

Describe the solution you'd like:

If there's a way to bypass the name check or instead add a Performance Counter support in opentelemetry as a feature, this can be done!

Considered Alternatives

No response

Additional Context

No response

@anujnegi270 anujnegi270 added the enhancement New feature or request label Jan 17, 2025
@lalitb
Copy link
Member

lalitb commented Jan 17, 2025

If there's a way to bypass the name check or instead add a Performance Counter support in opentelemetry as a feature, this can be done!

I think you need to normalize the PerfC names to fit the expected format. The instrument name format is coming from the specs, and can't be bypassed in the SDK.

@cijothomas cijothomas transferred this issue from open-telemetry/opentelemetry-rust-contrib Jan 21, 2025
@cijothomas
Copy link
Member

Moving to otel-rust repo, as naming validation is part of Otel API/SDK, not exporter.

@anujnegi270
Copy link
Author

anujnegi270 commented Jan 21, 2025 via email

@cijothomas
Copy link
Member

Sharing one issue in the spec which is also asking to relax naming requirement: open-telemetry/opentelemetry-specification#4371

While we wait spec movement, @lalitb is it okay to offer a "experimental_metrics_disable_name_validation" feature flag to bypass the validation to unblock users? I don't see any other way to report Windows Performance Counters which uses names disallowed by Otel....

@lalitb
Copy link
Member

lalitb commented Jan 21, 2025

@Cijo i think it make sense to have it under experimental flag.

@cijothomas
Copy link
Member

Okay.

@anujnegi270 Feel free to send a PR to bypass the validation, under a feature flag "experimental_metrics_disable_name_validation".

@anujnegi270
Copy link
Author

anujnegi270 commented Jan 22, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants