Disabling the Instrument Name Validation under a new feature flag #2543
+79
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anujnegi270
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for the feature [Feature]: A Dev Feature for Naming Convention used in Windows Performance Counters · Issue #2527 · open-telemetry/opentelemetry-rust and a related issue .
Fixes #
This fix is done under a feature flag
experimental_metrics_disable_name_validation, where all types of instrument name are acceptable except empty names and names exceeding the length limit.Changes
Defining the validation check function under the feature flag to bypass and return Ok().
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes