Metrics aggregate map is generic over temporality #2530
+313
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Same functionality as in #2506, but in my opinion a bit simpler and even cleaner.
The thing that I especially like, is how elegant is concrete implementation for an aggregation.
Yep, that's full implementation for
Sum
:) all the other common stuff is inaggregate_impl.rs
file.I deliberately didn't remove existing code, so it would be easier to evaluate this new design, and once we're happy with it, we can apply it.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes