Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define how SDK implements Logger.Enabled #4381

Merged
merged 20 commits into from
Jan 23, 2025
Merged

Define how SDK implements Logger.Enabled #4381

merged 20 commits into from
Jan 23, 2025

Conversation

pellared
Copy link
Member

@pellared pellared commented Jan 22, 2025 •
edited
Loading

@pellared pellared added the spec:logs Related to the specification/logs directory label Jan 22, 2025
@pellared pellared self-assigned this Jan 22, 2025
@pellared pellared changed the title Define SDK's Logger.Enabled Define how SDK implements Logger.Enabled Jan 22, 2025
@pellared pellared marked this pull request as ready for review January 22, 2025 15:44
@pellared pellared requested review from a team as code owners January 22, 2025 15:44
dashpole
dashpole reviewed Jan 22, 2025
View reviewed changes
specification/logs/sdk.md Outdated Show resolved Hide resolved
@pellared pellared requested a review from dashpole January 22, 2025 16:46
MrAlias
MrAlias reviewed Jan 22, 2025
View reviewed changes
specification/logs/sdk.md Outdated Show resolved Hide resolved
MrAlias
MrAlias reviewed Jan 22, 2025
View reviewed changes
specification/logs/sdk.md Outdated Show resolved Hide resolved
lalitb
lalitb approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@pellared pellared requested a review from cijothomas January 22, 2025 18:43
@jack-berg jack-berg mentioned this pull request Jan 22, 2025
Open
jack-berg
jack-berg approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I think all of this is implied elsewhere (except the "there are no registered LogRecordProcessors" part), but good to be explicit. Should followup by doing the same with traces and metrics. Feel free to do that if you'd like, or simply open an issue to track the followup - I'm not trying to volunteer you for more work.

lmolkova
lmolkova approved these changes Jan 23, 2025
View reviewed changes
specification/logs/noop.md Outdated Show resolved Hide resolved
@pellared @lmolkova
Update specification/logs/noop.md
021973e 
Co-authored-by: Liudmila Molkova <[email protected]>
@reyang reyang merged commit c55ed5c into open-telemetry:main Jan 23, 2025
6 checks passed
@pellared pellared deleted the sdk-logger-enabled branch January 23, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-berg jack-berg jack-berg approved these changes

@reyang reyang reyang approved these changes

@MrAlias MrAlias MrAlias approved these changes

@cijothomas cijothomas cijothomas approved these changes

@dashpole dashpole dashpole approved these changes

@lmolkova lmolkova lmolkova approved these changes

@lalitb lalitb lalitb approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

Assignees

@pellared pellared

Labels
spec:logs Related to the specification/logs directory
Projects
Go: Logs (GA)
Status: Done
Logs SIG
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@pellared @carlosalberto @lalitb @lmolkova @dashpole @cijothomas @MrAlias @reyang @jack-berg