Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude exception.escaped from (to-be-stable) artifact #133

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Exclude exception.escaped from (to-be-stable) artifact #133

wants to merge 2 commits into from
+13 −63

Conversation

trask
Copy link
Member

@trask trask commented Jan 8, 2025 •
edited
Loading

@trask trask requested review from a team as code owners January 8, 2025 22:10
@trask trask mentioned this pull request Jan 8, 2025
Open
@trask
Copy link
Member Author

trask commented Jan 8, 2025

oops, need to fix javadoc, incubating constant is deprecated referencing the stable constant

@lmolkova
Copy link
Contributor

lmolkova commented Jan 8, 2025

oops, need to fix javadoc, incubating constant is deprecated referencing the stable constant

maybe we should exclude it from incubating artifact too?

@trask
Copy link
Member Author

trask commented Jan 8, 2025

oops, need to fix javadoc, incubating constant is deprecated referencing the stable constant

maybe we should exclude it from incubating artifact too?

yeah, this is certainly easier, we can always bring it back (as deprecated) in the incubating artifact later

@trask trask requested a review from jack-berg January 8, 2025 22:35
@trask
Copy link
Member Author

trask commented Jan 8, 2025

oops, need to fix javadoc, incubating constant is deprecated referencing the stable constant

maybe we should exclude it from incubating artifact too?

yeah, this is certainly easier, we can always bring it back (as deprecated) in the incubating artifact later

@jack-berg I reset your approval to make sure you're ok with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-berg jack-berg jack-berg approved these changes

@lmolkova lmolkova lmolkova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trask @lmolkova @jack-berg