Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prepare-release-branch, update changelog for 1.23.1 release #39

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

jack-berg
Copy link
Member

The prepare-release-branch.yml task partially failed preparing for the 1.23.1 release: https://github.com/open-telemetry/semantic-conventions-java/actions/runs/6950081231/job/18909546619

Apparently it expected the version to match x.x.0, though I don't see anything that depends on the patch being 0.

This PR fixes the github action and manually performs the update to CHANGELOG.md it performs.

@jack-berg jack-berg requested a review from a team November 21, 2023 22:14
Copy link

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Bummer it got tripped up, but....progress.

@jack-berg jack-berg merged commit 486a534 into open-telemetry:main Nov 21, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants