Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-48103: rename 'master' to 'main' for vmware-vsphere-csi-driver-operator #60446

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DennisPeriquet
Copy link
Contributor

This PR is in support of renaming the default branch for https://github.com/openshift/vmware-vsphere-csi-driver-operator from 'master' to 'main'.

Unhold this PR only when:

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 8, 2025
@openshift-ci-robot
Copy link
Contributor

@DennisPeriquet: This pull request references Jira Issue OCPBUGS-48103, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR is in support of renaming the default branch for https://github.com/openshift/vmware-vsphere-csi-driver-operator from 'master' to 'main'.

Unhold this PR only when:

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 8, 2025
Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DennisPeriquet
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from bertinatto and pruan-rht January 8, 2025 19:56
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@DennisPeriquet: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-vmware-vsphere-csi-driver-operator-main-e2e-vsphere openshift/vmware-vsphere-csi-driver-operator presubmit Presubmit changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-main-e2e-vsphere-csi openshift/vmware-vsphere-csi-driver-operator presubmit Presubmit changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-main-e2e-vsphere-csi-extended openshift/vmware-vsphere-csi-driver-operator presubmit Presubmit changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-main-e2e-vsphere-operator-test openshift/vmware-vsphere-csi-driver-operator presubmit Presubmit changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-main-e2e-vsphere-ovn-upgrade openshift/vmware-vsphere-csi-driver-operator presubmit Presubmit changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-main-e2e-vsphere-zones openshift/vmware-vsphere-csi-driver-operator presubmit Presubmit changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-main-images openshift/vmware-vsphere-csi-driver-operator presubmit Presubmit changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-main-okd-scos-e2e-aws-ovn openshift/vmware-vsphere-csi-driver-operator presubmit Presubmit changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-main-okd-scos-images openshift/vmware-vsphere-csi-driver-operator presubmit Presubmit changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-main-security openshift/vmware-vsphere-csi-driver-operator presubmit Presubmit changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-main-unit openshift/vmware-vsphere-csi-driver-operator presubmit Presubmit changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-main-verify openshift/vmware-vsphere-csi-driver-operator presubmit Presubmit changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-main-verify-deps openshift/vmware-vsphere-csi-driver-operator presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

@DennisPeriquet: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants