-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build image from source for PR checks #60453
base: master
Are you sure you want to change the base?
Conversation
2109e69
to
0ee44a0
Compare
0ee44a0
to
7234bea
Compare
@@ -34,7 +37,8 @@ tests: | |||
oc apply --server-side -k "github.com/opendatahub-io/kueue/config/rhoai?ref=dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused here on the manifests that would be present during the PJ rehearsal. Would it make sense to just get rid of this conditional all together? @sutaakar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition is here to specify what kueue code is used for PJ rehearsal runs.
As the PJ rehearsal doesn't run against PR then there is used manifest from default branch.
7234bea
to
2a4493b
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sutaakar How would I go about testing this? |
@KPostOffice can you put the replacement code also to the PR rehearsal branch (the one with our comments)? |
Signed-off-by: Kevin <[email protected]>
2a4493b
to
3e07b60
Compare
/pj-rehearse |
@KPostOffice: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
@KPostOffice: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Code changes were not being reflected in e2e tests in the PR checks. This should build the image with up to date source code in the case that our patches are more than just manifest changes.