Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build image from source for PR checks #60453

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KPostOffice
Copy link
Contributor

Code changes were not being reflected in e2e tests in the PR checks. This should build the image with up to date source code in the case that our patches are more than just manifest changes.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2025
@@ -34,7 +37,8 @@ tests:
oc apply --server-side -k "github.com/opendatahub-io/kueue/config/rhoai?ref=dev"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused here on the manifests that would be present during the PJ rehearsal. Would it make sense to just get rid of this conditional all together? @sutaakar

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition is here to specify what kueue code is used for PJ rehearsal runs.
As the PJ rehearsal doesn't run against PR then there is used manifest from default branch.

Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KPostOffice
Copy link
Contributor Author

@sutaakar How would I go about testing this?

@sutaakar
Copy link
Contributor

sutaakar commented Jan 9, 2025

@KPostOffice can you put the replacement code also to the PR rehearsal branch (the one with our comments)?
Then you can invoke run with comment /pj-rehearse

@KPostOffice
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@KPostOffice: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@KPostOffice: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-kueue-dev-images opendatahub-io/kueue presubmit Presubmit changed
pull-ci-opendatahub-io-kueue-dev-e2e-odh-kueue opendatahub-io/kueue presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

@KPostOffice: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/opendatahub-io/kueue/dev/images 3e07b60 link unknown /pj-rehearse pull-ci-opendatahub-io-kueue-dev-images
ci/rehearse/opendatahub-io/kueue/dev/e2e-odh-kueue 3e07b60 link unknown /pj-rehearse pull-ci-opendatahub-io-kueue-dev-e2e-odh-kueue

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants