PODAUTO-266: Update VPA-operator master config to 4.19 #60455
Conversation
|
@maxcao13: This pull request references PODAUTO-266 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
approved
|
@maxcao13: This pull request references PODAUTO-266 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pj-rehearse max |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
maxcao13
force-pushed
the
vpa-operator-release-chores-4.19
branch
from
37a1edd to
756da9a
Compare
|
/pj-rehearse pull-ci-openshift-vertical-pod-autoscaler-operator-master-lint |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-vertical-pod-autoscaler-operator-master-lint It shouldn't be using the old config in the rehearsal... Try again today? |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
maxcao13
force-pushed
the
vpa-operator-release-chores-4.19
branch
from
756da9a to
2830434
Compare
|
/pj-rehearse max Try all rehearsals again with a force push, maybe the config didn't change the first time. |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Also removes golangci-lint base image in "lint" test. We can use the src container directly since we are downloading the correct golangci-lint version using "go install" from GOPROXY. Signed-off-by: Max Cao <[email protected]>
maxcao13
force-pushed
the
vpa-operator-release-chores-4.19
branch
from
2830434 to
111bd8e
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
Lint seems to finally pass. But upgrade test failed, let's just try to increase the deployment wait --for=creation timeout. OLM test also didn't finish but it seems the actual tests passed but was just stuck in de-provisioning phase: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/60455/rehearse-60455-pull-ci-openshift-vertical-pod-autoscaler-operator-master-e2e-aws-olm/1877408370441326592 /pj-rehearse pull-ci-openshift-vertical-pod-autoscaler-operator-master-e2e-aws-upgrade pull-ci-openshift-vertical-pod-autoscaler-operator-master-e2e-aws-olm |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 similar comment
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-vertical-pod-autoscaler-operator-master-e2e-aws-upgrade |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@maxcao13: job(s): abort, either don't exist or were not found to be affected, and cannot be rehearsed |
|
Unfortunately, I think we are not able to pass the upgrade because the upgrade doesn't work. I think it's trying to upgrade from 4.18 -> 4.18 in the upgrade logs: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_release/60455/rehearse-60455-pull-ci-openshift-vertical-pod-autoscaler-operator-master-e2e-aws-upgrade/1877458433674842112/artifacts/e2e-aws-upgrade/upgrade/build-log.txt @joelsmith Are we okay with just ignoring this rehearsal failure? I'm not 100% sure but I think it's failing because the vpa-operator repository hasn't updated it's The other and maybe better option is to ignore the lint failure in the release chore PR first and merge it first. Everything else passed rehearsals though, so that's good.
|
|
I am okay to ignore it. We can test it once the chores PR lands. Thanks! /ltgm |
|
Oops, typo! Apparently the bot does not accept "Looks too good, man!" /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelsmith, maxcao13 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks! /pj-rehearse ack |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
@maxcao13: This pull request references PODAUTO-266 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@maxcao13: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit f904506
into
openshift:master
Also bumps the mirrored golangci-lint image version to work with go1.23. The latest mirrored image is shown here:release/core-services/image-mirroring/_config.yaml
Lines 726 to 727 in 1f639d4
EDIT: Ignore above. This PR deprecates the use of the mirrored image since the vpa-operator repo uses
go installdirectly in the environment to installgolangci-lintwhich works if the image uses a compatible go version and allows internet access. So there is no need for that image.Also changes a step in the
e2e-aws-upgradeworkflow to useoc wait --for=createwhich was added in kubectl 1.31. I'm assuming it should be included in oc version 4.19 (since oc4.19 <-> k8s1.32). We also are specifyingcli: latestin the test so let's see if it works.