fix: update remoteEntryChunk code to handle base path correctly when … #661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Vite config is present
Description
The issue addressed is Duplicate assetsDir in _federation_expose #657.
Before accessing
viteConfigResolved.config.base
, the code now checks ifviteConfigResolved.config.base
is configured. If it is, it concatenates it withassetsDir
; otherwise, a fallback path (./${slashPath}
) is used instead.Additional context
This concatenation error caused incorrect paths in the generated
remoteEntry
file, leading to runtime issues in production builds.The dynamicLoadingCss function now synchronizes the base parameter provided by Vite configuration, ensuring correct path resolution for dynamically loaded CSS files.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).