Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update remoteEntryChunk code to handle base path correctly when … #661

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

Skywang16
Copy link

@Skywang16 Skywang16 commented Jan 9, 2025

…Vite config is present

Description

The issue addressed is Duplicate assetsDir in _federation_expose #657.

Before accessing viteConfigResolved.config.base, the code now checks if viteConfigResolved.config.base is configured. If it is, it concatenates it with assetsDir; otherwise, a fallback path (./${slashPath}) is used instead.

Additional context

This concatenation error caused incorrect paths in the generated remoteEntry file, leading to runtime issues in production builds.
The dynamicLoadingCss function now synchronizes the base parameter provided by Vite configuration, ensuring correct path resolution for dynamically loaded CSS files.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Code of Conduct and follow the Commit Convention guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ruleeeer ruleeeer merged commit 766b521 into originjs:main Jan 11, 2025
8 checks passed
@ruleeeer
Copy link
Collaborator

Thank you, I will release a version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants