chore(benchmark): add radix-ui.jsx as a real world jsx example #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oxc canceled.
|
CodSpeed Performance ReportMerging #2304 will not alter performanceComparing Summary
Benchmarks breakdown
|
|
Let me copy this file over to oxc-project/benchmark-files, since this file can change overtime. |
Boshen
approved these changes
Feb 5, 2024
|
Ah of course, I didn't consider that the files could change. Doh! I should have used a permalink. If you prefer to avoid hosting the files in an OXC repo, here's the permalink for the one I added: Not sure which file you took from cal.com, but could take the same approach for that. If you want to, let me know which file and I'll make a PR. |
|
It's already done ;-) |
|
OK cool! |
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
…roject#2304) Following oxc-project#2297, this adds another benchmark. This one is from radix-ui website. I've chosen this particular file because it differs from the other benchmark sources in 3 ways: 1. JSX not TSX (despite the file extension). 2. Contains no logic, only JSX component hierarchy, and content text. 3. Very small (60 LOC). The last is particularly important, I think. Often developers will be working on small files (single component per file convention). And some possible directions for the parser (SIMD etc) involve optimizing chewing through chunks of text, with a de-opt at the end to process the final batch of bytes. If that imposes a penalty on short files, this benchmark will surface it. --------- Co-authored-by: Boshen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #2297, this adds another benchmark.
This one is from radix-ui website. I've chosen this particular file because it differs from the other benchmark sources in 3 ways:
The last is particularly important, I think. Often developers will be working on small files (single component per file convention). And some possible directions for the parser (SIMD etc) involve optimizing chewing through chunks of text, with a de-opt at the end to process the final batch of bytes. If that imposes a penalty on short files, this benchmark will surface it.