Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): implement no-lone-blocks rule #8145

Merged
merged 7 commits into from
Jan 13, 2025

Conversation

baseballyama
Copy link
Contributor

@baseballyama baseballyama commented Dec 27, 2024

Copy link

graphite-app bot commented Dec 27, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Dec 27, 2024
@baseballyama baseballyama force-pushed the feat/lint/no-lone-blocks branch from 6b0ede0 to 8f4c5c8 Compare December 27, 2024 12:14
Copy link

codspeed-hq bot commented Dec 27, 2024

CodSpeed Performance Report

Merging #8145 will not alter performance

Comparing baseballyama:feat/lint/no-lone-blocks (cd187e0) with main (372eb09)

Summary

✅ 29 untouched benchmarks

@baseballyama
Copy link
Contributor Author

This PR uses span() 4 times but I think we can not convert it to span.

related: #8149 (comment)

@baseballyama baseballyama force-pushed the feat/lint/no-lone-blocks branch from 41327f9 to d272fe5 Compare December 27, 2024 19:44
@baseballyama baseballyama requested a review from camc314 December 27, 2024 19:45
Copy link
Contributor

@camchenry camchenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Sysix
Copy link
Collaborator

Sysix commented Jan 9, 2025

Hello ✋
we updated the tests for rules in this PR: #8353
Could you please rebase/merge your PR with main foir the needed changes? 🙌?
You probably need it too for your other 3 PRs :)

@baseballyama baseballyama force-pushed the feat/lint/no-lone-blocks branch from 18f9f73 to c3bdab0 Compare January 13, 2025 01:11
@baseballyama
Copy link
Contributor Author

@Sysix Did!

@Boshen Boshen merged commit 457aa31 into oxc-project:main Jan 13, 2025
26 checks passed
@baseballyama baseballyama deleted the feat/lint/no-lone-blocks branch January 13, 2025 01:38
Boshen added a commit that referenced this pull request Jan 13, 2025
## [0.15.6] - 2025-01-13

### Features

- 457aa31 linter: Implement `no-lone-blocks` rule (#8145) (Yuichiro
Yamashita)

### Refactor

- aea9551 ast: Simplify `get_identifier_reference` of `TSType` and
`TSTypeName` (#8273) (Dunqing)
- 43ed3e1 linter: Add output formatter (#8436) (Alexander S.)
- 4e05e66 linter: Remove glob for windows (#8390) (Alexander S.)
- b19d809 linter: Split `unicorn/prefer-spread` and
`eslint/prefer-spread` into own rules (#8329) (Alexander S.)
- 3c534ae linter: Refactor `LintBuilder` to prep for nested configs
(#8034) (camc314)
- 2f9fab9 linter: Remove remapping for plugin name in diagnostics
(#8223) (Alexander S.)

### Testing

- b6c1546 linter: Use plugin name instead of category for finding rule
(#8353) (Alexander S.)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants