Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(semantic): do not need to handle type resolving when it is not a typescript code #8613

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 20, 2025

No description provided.

@Dunqing Dunqing requested a review from Boshen as a code owner January 20, 2025 10:37
@github-actions github-actions bot added the A-semantic Area - Semantic label Jan 20, 2025
Copy link
Member Author

Dunqing commented Jan 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Jan 20, 2025
@Dunqing Dunqing marked this pull request as draft January 20, 2025 10:42
Copy link

codspeed-hq bot commented Jan 20, 2025

CodSpeed Performance Report

Merging #8613 will not alter performance

Comparing 01-20-perf_semantic_do_not_need_to_handle_type_resolving_when_it_is_not_a_typescript_code (8711e0a) with main (d9f5e7f)

Summary

✅ 32 untouched benchmarks

@Dunqing Dunqing force-pushed the 01-20-perf_semantic_do_not_need_to_handle_type_resolving_when_it_is_not_a_typescript_code branch from 2f386ae to 8711e0a Compare January 20, 2025 11:01
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Jan 20, 2025
@Dunqing
Copy link
Member Author

Dunqing commented Jan 21, 2025

It is not good, I don't know why, close it as it is not worth digging into it now

@Dunqing Dunqing closed this Jan 21, 2025
@Boshen Boshen deleted the 01-20-perf_semantic_do_not_need_to_handle_type_resolving_when_it_is_not_a_typescript_code branch January 21, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant